search

kubernetes-sigs / image-builder

Tools for building Kubernetes disk images
https://image-builder.sigs.k8s.io/
Apache License 2.0
372 stars 379 forks source link

Keep mandatory presubmit ci working after 1st of august #1508

Open chrischdi opened 1 month ago

chrischdi commented 1 month ago

Hey folks,

the presubmit prowjob pull-ova-all is backed by infrastructure which is not owned by the community. Starting by the 1st of August this job will not work anymore. (see this mail for more information)

We are working on it but do not yet have any estimate yet when we will have community owned infrastructure to run this job after 1st of August (also see this mail).

This prowjob currently is currently used as a signal to merge PRs and is mandatory to be green for merging, when the following paths have changes in a PR:

Before hitting 1st of august we propably should:

chrischdi commented 1 month ago

Adding all currently listed maintainers for awareness :-) :

@AverageMarcus, @jsturtevant, @kkeshavamurthy, @mboersma, @drew-viles

cc @fabriziopandini @sbueringer

mboersma commented 1 month ago

Thanks for the heads up @chrischdi. I'm working on the changes for the pull-azure-vhds and pull-azure-sigs to migrate them to community infra and should be able to land that before August 1, so we will at least have some test signal against basic regressions.

It would be great if we could rehabilitate pr-pull-image-builder-gcp-all as well. I can take a look after I finish this work, but if anyone wants to volunteer before that, that would be excellent.

drew-viles commented 1 month ago

I'll be honest, I've not touched anything prow yet so wouldn't know right now where to start. Would love to see how it's done though if I can shadow through the process as PRs are raised etc?

For example I can see how I'd disable it by removing the run_if_changed section but I'm not clear on how it'd be made optional. As for the gcp one, I've not a clue right now!

Time to level myself up a bit around this section šŸ˜‰

chrischdi commented 1 month ago

I'll be honest, I've not touched anything prow yet so wouldn't know right now where to start. Would love to see how it's done though if I can shadow through the process as PRs are raised etc?

For example I can see how I'd disable it by removing the run_if_changed section but I'm not clear on how it'd be made optional. As for the gcp one, I've not a clue right now!

Time to level myself up a bit around this section šŸ˜‰

Making it optional is only about adding optional: true to the pull-ova-all job in this file:

https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/image-builder/image-builder-ova-presubmits.yaml#L8

Prior art:

https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/image-builder/image-builder-presubmits.yaml#L51

Happy to give guidance :-)

mboersma commented 1 month ago

WRT to the broken pull-image-builder-gcp-all job, see #1516.

mboersma commented 1 month ago

The two Azure prow jobs are now moved over to community infra, so that's everything except pull-ova-all.

@chrischdi please let us know if we can help with anything, or if we should go ahead and make pull-ova-all optional. I can take a look at fixing pull-image-builder-gcp-all next week.

sbueringer commented 1 month ago

@mboersma Please make pull-ova-all optional. We don't have community-owned infrastructure for vSphere yet, and we won't get it until 1st August

mboersma commented 1 month ago

Please make pull-ova-all optional

See kubernetes/test-infra#33052

drew-viles commented 1 month ago

Thanks for sorting this @mboersma . Sorry I've not had chance to jump on this. It's been a mad week at home so just not had chance to log in and do much.