Closed aslafy-z closed 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign richardcase for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @aslafy-z. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Hi,
I'm not seeing anything from Google to suggest there is a removal of N1 instances happening anywhere and it's still listed in their workload types. The N1 machines are generally cheaper to run which is why this option was set originally I suspect - Though in Europe it looks to be the same now tbh.
You can override this via your own configuration file too so I'd recommend taking that approach for now: https://github.com/kubernetes-sigs/image-builder/blob/main/docs/book/src/capi/capi.md
PACKER_VAR_FILES=var_file_1.json make ...
I mean, I'm no GCE expert for what it's worth so happy to be told otherwise! 😄
Yeah I think I agree with @drew-viles on this unless there is actual indication that the n1
series is being phased out.
The price difference is quite a lot and could be a surprise for users that use the defaults and builds a lot of images.
n1-standard-1
- $0.055
n2-standard-2
- $0.133382
As Drew points out, machine_type
can be provided in the user vars to override this value.
Maybe we could get away with just updating the GCP docs to point this out specifically?
Thank you for the feedback! I opened https://github.com/kubernetes-sigs/image-builder/pull/1608 to update the documentation. Closing this PR.
Change description
N1 machines are less and less available. I could not build my image in multiple zones of european regions. N2 seams to be more available.