search

kubernetes-sigs / image-builder

Tools for building Kubernetes disk images
https://image-builder.sigs.k8s.io/
Apache License 2.0
402 stars 394 forks source link

Remove windows-2019 and -2025 targets from CI #1604

Closed mboersma closed 1 month ago

mboersma commented 1 month ago

Change description

Removes the Azure windows-2019 and windows-2025 targets from CI runs, since they are both failing and blocking unrelated PRs from merging.

Related issues

mboersma commented 1 month ago

/test pull-azure-vhds /test pull-azure-sigs

AverageMarcus commented 1 month ago

@mboersma Are these targets actually broken or just in CI? As in, do we want to drop support for building these completely?

mboersma commented 1 month ago

/test pull-azure-sigs

@AverageMarcus, as far as I can tell, the windows-2019 targets are broken and maybe we should remove them altogether, although @jsturtevant should weigh in. The windows-2025 target supposedly only fails in CI, and needs to be fixed and supported.

mboersma commented 1 month ago

/test pull-azure-sigs

Two unrelated flakes and a timeout. :-( Not sure why things are going badly here, I'm running ./images/capi/scripts/ci-azure-e2e.sh locally to see if I can reproduce.

jsturtevant commented 1 month ago

/lgtm /approve

The time of the failures aligns with patch Tuesday last week. 2019 is technically EOL and only receiving security patches right now so likely ok to remove from CI.

@TinaMor fyi on 2025, hopefully we just need to increase the timeout to make this pass.

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/image-builder/blob/main/OWNERS)~~ [jsturtevant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment