kubernetes-sigs / image-builder

Tools for building Kubernetes disk images
https://image-builder.sigs.k8s.io/
Apache License 2.0
402 stars 394 forks source link

Skip Get-WindowsFeature goss spec for windows-2025 #1619

Closed mboersma closed 1 month ago

mboersma commented 1 month ago

Change description

Tries the Get-WindowsFeature goss test spec twice to work around an issue with windows-2025. Also restores the Azure windows-2025 build to CI runs.

Related issues

Additional context

mboersma commented 1 month ago

/cc @jsturtevant @TinaMor

k8s-ci-robot commented 1 month ago

@mboersma: GitHub didn't allow me to request PR reviews from the following users: TinaMor.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/image-builder/pull/1619#issuecomment-2429875824): >/cc @jsturtevant @TinaMor Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mboersma commented 1 month ago

/test pull-azure-sigs

mboersma commented 1 month ago

/retitle Skip Get-WindowsFeature goss spec for windows-2025

mboersma commented 1 month ago

/test pull-azure-sigs

Edit: sig-windows-2025-containerd: SUCCESS

jsturtevant commented 1 month ago

Unfortunate that the powershell command doesn't work properly on Windows 2025.

/lgtm /approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/image-builder/blob/main/OWNERS)~~ [jsturtevant] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment