Override SSH password - Githubissues

0nebody commented 4 days ago

Change description

Allow the SSH password to be set from the environment. Defaults to generated password.

Required for build-node-ova-vsphere-clone-* as the cloned instance must have access to the password set in the base image.

k8s-ci-robot commented 4 days ago

Hi @0nebody. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

AverageMarcus commented 4 days ago

/ok-to-test /lgtm /assign @drew-viles @mboersma

drew-viles commented 4 days ago

/approve

k8s-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drew-viles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/image-builder/blob/main/OWNERS)~~ [drew-viles] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-sigs / image-builder

Override SSH password #1629

Change description