kubernetes-sigs / image-builder

Tools for building Kubernetes disk images
https://image-builder.sigs.k8s.io/
Apache License 2.0
401 stars 394 forks source link

Windows 2025 images are -gen2? #1630

Open mboersma opened 1 day ago

mboersma commented 1 day ago

Environment

What steps did you take and what happened?

I ran make build-azure-sig-windows-2025 through our ADO pipeline, but it refused to promote to the community gallery because the image definition defaulted to hypervisor gen1 and apparently the image is gen2.

What did you expect to happen?

This doesn't happen for any other Azure SIG builds, so I'm assuming this target actually built a -gen2 image. But we use the convention of adding "-gen2" to those targets, so if that's the case we need to change the target name.

Relevant log output

Log Output ```shell az sig image-version create --resource-group cluster-api-gallery --gallery-name community_gallery --gallery-image-definition capi-win-2025-containerd --gallery-image-version 1.31.2 --target-regions northcentralus australiaeast canadacentral francecentral germanywestcentral northeurope switzerlandnorth uksouth --managed-image /subscriptions/46678f10-4bbb-447e-98e8-d2829589f2d8/resourceGroups/cluster-api-gallery/providers/Microsoft.Compute/images/capi-windows-2025-containerd-1731695676 --end-of-life-date 2025-05-15T00:00:00+00:00 --tags PlanInfo=windows-server-2025-azure-edition-hotpatch PlanProduct=microsoftserveroperatingsystems-previews PlanPromotionCode= PlanPublisher=microsoftwindowsserver build_date=2024-11-15T18:34:36Z build_timestamp=1731695676 creationTimestamp=2024-11-15T18:34:36Z image_builder_version=v0.1.39-19-g7074eac20-dirty kubernetes_version=v1.31.2 os_version=windows-server-2025-azure-edition-hotpatch + tee -a sig-publishing.json ERROR: (Conflict) The resource with id '/subscriptions/46678f10-4bbb-447e-98e8-d2829589f2d8/resourceGroups/cluster-api-gallery/providers/Microsoft.Compute/images/capi-windows-2025-containerd-1731695676' has a different Hypervisor generation ['V2'] than the parent gallery image Hypervisor generation ['V1']. Code: Conflict Message: The resource with id '/subscriptions/46678f10-4bbb-447e-98e8-d2829589f2d8/resourceGroups/cluster-api-gallery/providers/Microsoft.Compute/images/capi-windows-2025-containerd-1731695676' has a different Hypervisor generation ['V2'] than the parent gallery image Hypervisor generation ['V1']. ```

/kind bug