search

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

Requests to echoserver can specify response headers to return #100

Closed sunjayBhatia closed 2 years ago

sunjayBhatia commented 2 years ago

Specified using the X-Echo-Set-Header request header. The header value is a comma separated list of header name and value pairs separated by a colon. Casing of header names to return is preserved for testing that needs this.

Part of https://github.com/kubernetes-sigs/gateway-api/issues/1473

k8s-ci-robot commented 2 years ago

Hi @sunjayBhatia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sunjayBhatia commented 2 years ago

/cc @shaneutt @robscott

robscott commented 2 years ago

Thanks @sunjayBhatia!

/ok-to-test

sunjayBhatia commented 2 years ago

ah, so repeated usage of a header is discouraged by RFC 7230, so will change to a single header with a comma separated list of headers

sunjayBhatia commented 2 years ago

/hold

sunjayBhatia commented 2 years ago

/unhold

robscott commented 2 years ago

Thanks @sunjayBhatia!

/lgtm /assign @bowei

bowei commented 2 years ago

/approve /lgtm

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment