search

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

Migrate away from google.com gcp project k8s-testimages #107

Closed cpanato closed 2 months ago

cpanato commented 1 year ago

What type of PR is this? /kind cleanup

What this PR does / why we need it:

Related to https://github.com/kubernetes/k8s.io/issues/1523

/assign @ameukam @thockin @bowei

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Does this PR introduce a user-facing change?:

NONE
cpanato commented 1 year ago

/retest

cpanato commented 1 year ago

Why test-infra and not a subproject-specific GCP project?

good question to @ameukam

ameukam commented 1 year ago

Why test-infra and not a subproject-specific GCP project?

k8s-staging-test-infra is currently is community-owned and used specifically to host the images maintained by SIG Testing. I don't correctly remember the specifics about why this name (early days of the migration to k8s-infra for those images) but my guess is test-infra "helps" to easily identify where the Dockerfiles of those images are located.

thockin commented 1 year ago

test-infra doesn't seem right for testing ingress-controllers, though - we do already have k8s-staging-ingress-controller-conformance.

From as directional POV, what do we want as a project?

1) humans don't touch artifacts 2) bots and automation exclusively manage them

As such, it seems like building it in the same project that has the staging GCR is the right thing to do...

thockin commented 1 year ago

What do we do with this? Approve or try to adjust?

thockin commented 1 year ago

ping @robscott @bowei

robscott commented 1 year ago

These images had been used for Gateway API, but we actually just completed a migration away from them today (https://github.com/kubernetes-sigs/gateway-api/pull/2468). For the past several years, the only updates this repo was getting was just to update conformance images for Gateway API, so we decided to pull those into the main GW API repo and by extension k8s-staging-gateway-api in gcr.

I think this specific project is effectively archived at this point, and I don't know of anyone regularly running these tests. I'm not sure it's worth the effort to make changes here. Instead, I do know that the conformance images used by Gateway API will likely continue to get significant usage and updates, so if there are any similar improvements we could make there, definitely let us know.

ameukam commented 1 year ago

Instead, I do know that the conformance images used by Gateway API will likely continue to get significant usage and updates, so if there are any similar improvements we could make there, definitely let us know.

@robscott we can close this PR and request to archive this repo is done by sig-network ?

robscott commented 1 year ago

request to archive this repo is done by sig-network

I'm not 100% sure what to do here. We know that the Ingress API is essentially frozen and not going to change, which would suggest that these conformance tests would also not change. On the other hand, the Ingress API is not going away and archiving this repo may give the wrong message on that front. Interested in what others think here as well.

/cc @shaneutt @youngnick

cpanato commented 1 year ago

I completely lost track of this, sorry

I think this PR is only to change the deprecated image; if other things need to be done to push this repo to an up-to-date state, we can do it in a follow-up. I volunteer myself to do all the required work.

@robscott @ameukam @thockin

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/OWNERS)~~ [thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cpanato commented 1 year ago

@thockin we will need to override the failing checks to get this merged.

also what is the best slack channel to talk with you about next steps for this repo?

thockin commented 1 year ago

sig-network is the right channel, but if you need specific people you probably need to name them :)

thockin commented 1 year ago

/retest

I don't know much about these checks - @robscott ?

k8s-ci-robot commented 1 year ago

@cpanato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ingress-controller-conformance-gherkin 9ab53be770088295dc9f5aad86414b3e5573c292 link true /test pull-ingress-controller-conformance-gherkin

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
youngnick commented 1 year ago

Yeah, it makes sense to me to keep this around rather than going full archive.

cpanato commented 10 months ago

this is something we can skip to get this PR merged?

cc @thockin @youngnick @robscott

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 months ago

@k8s-triage-robot: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/ingress-controller-conformance/pull/107#issuecomment-2354046270): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the PR is closed > >You can: >- Reopen this PR with `/reopen` >- Mark this PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.