Closed jpeach closed 4 years ago
@aledbf I think has an interesting framework here that uses the sonabuoy compatible tests:
https://github.com/aledbf/ingress-conformance
maybe we can borrow something from this?
I think that the relative simplicity of the framework here is nice. The obvious downside is that of maintaining a separate framework, but maybe that won't be too painful if we keep it simple :)
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
/remove-lifecycle stale
Closing. The repository is already using BDD (a similar approach to aledbf/ingress-conformance)
/close
@aledbf: Closing this issue.
The conformance tests are organized in a hierarchy of
check.Check
structs. This makes initialization fairly verbose, but I'm not sure that the hierarchy is all that useful.If we drop the hierarchy, we could replace all the initialization, with something like this:
Alternatively, we could use reflection to find tests. Maybe we could add a regex argument to the
verify
subcommand to replace the grouping behavior of the current hierarchy.