search

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

Add tests for different path match modes: "Exact", "Prefix", and "ImplementationSpecific" #23

Closed alexgervais closed 4 years ago

alexgervais commented 4 years ago

With networking.k8s.io/v1beta1, paths are assumed to be regexes. Moving forward with networking.k8s.io/v1, we should explicitly assert each path types: "Exact", "Prefix", and "ImplementationSpecific"

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

bowei commented 4 years ago

/remove-lifecycle stale

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

aledbf commented 4 years ago

Closing. Done in https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/features/path_rules.feature

/close

k8s-ci-robot commented 4 years ago

@aledbf: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/ingress-controller-conformance/issues/23#issuecomment-670968534): >Closing. Done with https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/features/path_rules.feature > >/close > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.