search

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

Test suite and machinery decoupling, support for multiple apiversions and better usability #33

Closed alexgervais closed 4 years ago

alexgervais commented 4 years ago

I've been experimenting with improvements in the ingress-controller-conformance test suite for newly added features to the networking.k8s.io/v1beta1 API in k8s 1.18. This PR is a superset of changes introduced in https://github.com/kubernetes-sigs/ingress-controller-conformance/pull/9

I believe it'll be much easier to iterate and investigate using standard test frameworks (https://github.com/kubernetes-sigs/ingress-controller-conformance/issues/29) using this PR as a baseline. This PR already decouples the test suite from the test machinery and removes a lot of boilerplate. Although, I mostly wanted to make it public for gathering feedback and cherrypick the good parts.

The following issues were addressed in this branch:

cc. @bowei @jpeach

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexgervais To complete the pull request process, please assign bowei You can assign the PR to them by writing /assign @bowei in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jpeach commented 4 years ago

I scanned through this and it seems like it is heading in a reasonable direction. I'm a bit loth to invest the time in such a large review, but I can if it will help.

bowei commented 4 years ago

Is it possible to split in to smaller pieces?