Apply command creates and delete managed resources for multiple api-versions

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.

Apache License 2.0

43 stars 36 forks source link

Apply command creates and delete managed resources for multiple api-versions #35

Closed alexgervais closed 4 years ago

alexgervais commented 4 years ago

Extracted from work branch https://github.com/kubernetes-sigs/ingress-controller-conformance/pull/33 for easier code review.

The following issues were addressed in this branch:

Ingress class was removed from yaml (https://github.com/kubernetes-sigs/ingress-controller-conformance/issues/12)
Tests and deployment objects (managed through ingress-controller-conformance apply) must now specify an api-version parameter. This allows to setup a test suite for either extensions/v1beta1 or networking.k8s.io/v1beta1.
Updated README.md

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexgervais To complete the pull request process, please assign thockin You can assign the PR to them by writing /assign @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

alexgervais commented 4 years ago

/assign @bowei

First smaller chunk of https://github.com/kubernetes-sigs/ingress-controller-conformance/pull/33

Hopefully, it's mostly yaml moving around and changes to cmd/apply.go which should be easy and quick to review in preparation for the subsequent changes.