search

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

Support multiple versions of the Ingress api #40

Closed alexgervais closed 3 years ago

alexgervais commented 4 years ago

Although our aim is to provide conformance tests for networking.k8s.io/v1, ingress-controller implementors would benefit from having the ability to test against different versions of the spec: networking.k8s.io/v1beta1 and extensions/v1beta1.

Consider using annotation on Scenarios for each of the supported version of the spec: @networking.k8s.io/v1, @networking.k8s.io/v1beta1, @extensions/v1beta1

aledbf commented 4 years ago

For reference https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/20191023-conformance-without-beta.md

aledbf commented 4 years ago

/assign @bowei

bowei commented 4 years ago

We can do this, although extensions v1beta1 has been removed and the feature will go GA soon.

Probably only need: networking.v1beta1 and networking.v1 when it comes? Solution would likely be to vendor the version conversion utilities to make it easy to interoperate?

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

aledbf commented 3 years ago

networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress

This is already being returned by kubectl.

/close

k8s-ci-robot commented 3 years ago

@aledbf: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/ingress-controller-conformance/issues/40#issuecomment-700126120): >> networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress > >This is already being returned by kubectl. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.