search

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

fix: remove ingress class in default manifests #44

Closed hbagdi closed 4 years ago

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hbagdi To complete the pull request process, please assign thockin You can assign the PR to them by writing /assign @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hbagdi commented 4 years ago

@aledbf @alexgervais I was able to get things to run but I stumbled upon the default ingress class thing here, hence this PR.

hbagdi commented 4 years ago

/assign @aledbf

aledbf commented 4 years ago

@hbagdi with the work in https://github.com/kubernetes-sigs/ingress-controller-conformance/pull/43 the deployments directory can be removed

hbagdi commented 4 years ago

Sounds good. Closing this then.