search

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

Implement "delete" command to clean up conformance resources #45

Closed hbagdi closed 4 years ago

hbagdi commented 4 years ago

apply command currently applies the resources but the cleanup has to be performed manually. Implement a delete command to clean up the resources.

hbagdi commented 4 years ago

@aledbf @alexgervais Thoughts? I can take this up if this looks good.

aledbf commented 4 years ago

@hbagdi the creation (example https://github.com/kubernetes-sigs/ingress-controller-conformance/pull/43/files#diff-ce6002d1e71606ef4757a14e366d629aR10) and cleanup is part of the test itself https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/test/conformance/defaultbackend/feature.go#L52

aledbf commented 4 years ago

@alexgervais maybe the cmd can be removed once we merge #43?

alexgervais commented 4 years ago

Yes, the cmd, internal and deployments packages are to be removed once #43 is merged and its feature steps are implemented.

hbagdi commented 4 years ago

Sounds good. Closing this then.