kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

Cleanup project #54

Closed aledbf closed 4 years ago

aledbf commented 4 years ago

This PR removes yaml manifests to install an ingress controller, ingress examples, and go code used before godog.

The repository should post an example to run the conformance tests locally and as a container, like

  1. Create cluster using Kubernetes v1.19.0-rc.0
cat <<EOF | kind create cluster --config=-
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
  kubeadmConfigPatches:
  - |
    kind: InitConfiguration
    nodeRegistration:
      kubeletExtraArgs:
        node-labels: "ingress-ready=true"
  extraPortMappings:
  - containerPort: 80
    hostPort: 80
    protocol: TCP
  - containerPort: 443
    hostPort: 443
    protocol: TCP
EOF
  1. Install an ingress controller https://kind.sigs.k8s.io/docs/user/ingress - Ambassador, Contour, Ingress NGINX, etc.

kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/static/provider/kind/deploy.yaml

  1. Run tests

go test -v

/hold

aledbf commented 4 years ago

/assign @alexgervais

aledbf commented 4 years ago

/retest

alexgervais commented 4 years ago

@aledbf The README.md file will require a complete rewrite given the deleted code. Was it your plan to update it in this PR as well?

aledbf commented 4 years ago

Was it your plan to update it in this PR as well?

No. I would prefer doing that in a different one

aledbf commented 4 years ago

/hold cancel

aledbf commented 4 years ago

/assign @bowei

bowei commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment