search

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

Simplify build of reports #67

Closed aledbf closed 3 years ago

aledbf commented 3 years ago

The current code uses a java library that does not allow custom templates. This change switches to a node.js module and the template is customizable.

Output sample https://aledbf.github.io/ingress-conformance-sample/

aledbf commented 3 years ago

/assign @bowei

bowei commented 3 years ago

Can you clearly distinguish code that we wrote vs copied/vendored in from somewhere else? (ideally with separate commits)

aledbf commented 3 years ago

Can you clearly distinguish code that we wrote vs copied/vendored in from somewhere else? (ideally with separate commits)

done

aledbf commented 3 years ago

@bowei ping

bowei commented 3 years ago

/approve /lgtm

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment