search

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

Do not throw an error for mismatching SSL hostname #72

Closed aledbf closed 3 years ago

aledbf commented 3 years ago

Remove the certificate validation for a scenario creating a connection to an invalid host:

(some ingress controllers configure a default SSL certificate)

aledbf commented 3 years ago

/assign @alexgervais

aledbf commented 3 years ago

@alexgervais ready for another review :)

bowei commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment