Closed alexgervais closed 4 years ago
/assign @aledbf /assign @bowei
Makes sense
/approve
@robscott -- should we explicitly state this somewhere?
@bowei Is that something we could require in a backwards compatible way? If so, what would be the preferred approach?
@bowei @robscott what is missing/required to merge this change?
Let's remove this for the time being, as I don't think we specify this explicitly. @robscott this is something to think about though for service APIs, if we want to says something there.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aledbf, alexgervais, bowei
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Given the Ingress v1 specification itself does not define the expected behavior for request path prefixes: preserve, rewrite or strip, and given the Ingress resource has no way of informing that behavior either, I propose we remove the 'And the request path must be "/foo"' assertions.
For reference, the Ingress documentation states:
Ref: https://github.com/kubernetes/ingress-gce/issues/109, https://github.com/kubernetes/ingress-nginx/blob/master/docs/examples/rewrite/README.md