kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

Removing path assertions as the behavior is not part of the specification #79

Closed alexgervais closed 4 years ago

alexgervais commented 4 years ago

Given the Ingress v1 specification itself does not define the expected behavior for request path prefixes: preserve, rewrite or strip, and given the Ingress resource has no way of informing that behavior either, I propose we remove the 'And the request path must be "/foo"' assertions.

For reference, the Ingress documentation states:

Ingress frequently uses annotations to configure some options depending on the Ingress controller, an example of which is the rewrite-target annotation. Different Ingress controller support different annotations.

Ref: https://github.com/kubernetes/ingress-gce/issues/109, https://github.com/kubernetes/ingress-nginx/blob/master/docs/examples/rewrite/README.md

alexgervais commented 4 years ago

/assign @aledbf /assign @bowei

aledbf commented 4 years ago

Makes sense

/approve

bowei commented 4 years ago

@robscott -- should we explicitly state this somewhere?

robscott commented 4 years ago

@bowei Is that something we could require in a backwards compatible way? If so, what would be the preferred approach?

aledbf commented 4 years ago

@bowei @robscott what is missing/required to merge this change?

bowei commented 4 years ago

Let's remove this for the time being, as I don't think we specify this explicitly. @robscott this is something to think about though for service APIs, if we want to says something there.

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, alexgervais, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment