search

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

Generated self signed certs should be TLS secrets #88

Closed sunjayBhatia closed 3 years ago

sunjayBhatia commented 3 years ago

Currently the generated Opaque secret may not be supported by all Ingress controllers. Rather than making an Opaque secret that contains the relevant data by convention, explicilty create a TLS secret to remove ambiguity.

k8s-ci-robot commented 3 years ago

Welcome @sunjayBhatia!

It looks like this is your first PR to kubernetes-sigs/ingress-controller-conformance 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/ingress-controller-conformance has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 years ago

Hi @sunjayBhatia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sunjayBhatia commented 3 years ago

@bowei @thockin have you had a chance to take a look at this yet?

aledbf commented 3 years ago

/ok-to-test

aledbf commented 3 years ago

/lgtm

aledbf commented 3 years ago

/assign @bowei

sunjayBhatia commented 3 years ago

@bowei have you gotten a chance to review this?

sunjayBhatia commented 3 years ago

@aledbf @bowei have you had a chance to do a final review of this change?

aledbf commented 3 years ago

@sunjayBhatia I don't have approval permissions :( This change LGTM

sunjayBhatia commented 3 years ago

@bowei @thockin Are you able to give this a review? @aledbf reviewed and seems to approve

sunjayBhatia commented 3 years ago

This is needed so we can get Contour running Ingress conformance in CI

bowei commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment