search

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

fix(deps): bump golang.org/x/tools to make project build again on darwin #94

Closed pmalek closed 1 year ago

pmalek commented 2 years ago

This PR addresses the following compilation error on darwin (not sure about other OSes):

$ make build
# golang.org/x/sys/unix
../../.gvm/pkgsets/go1.18.2/global/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/syscall_darwin.1_13.go:29:3: //go:linkname must refer to declared function or variable
../../.gvm/pkgsets/go1.18.2/global/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.1_13.go:27:3: //go:linkname must refer to declared function or variable
../../.gvm/pkgsets/go1.18.2/global/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.1_13.go:40:3: //go:linkname must refer to declared function or variable
../../.gvm/pkgsets/go1.18.2/global/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:28:3: //go:linkname must refer to declared function or variable
../../.gvm/pkgsets/go1.18.2/global/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:43:3: //go:linkname must refer to declared function or variable
../../.gvm/pkgsets/go1.18.2/global/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:59:3: //go:linkname must refer to declared function or variable
../../.gvm/pkgsets/go1.18.2/global/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:75:3: //go:linkname must refer to declared function or variable
../../.gvm/pkgsets/go1.18.2/global/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:90:3: //go:linkname must refer to declared function or variable
../../.gvm/pkgsets/go1.18.2/global/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:105:3: //go:linkname must refer to declared function or variable
../../.gvm/pkgsets/go1.18.2/global/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:121:3: //go:linkname must refer to declared function or variable
../../.gvm/pkgsets/go1.18.2/global/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:121:3: too many errors
make: *** [ingress-controller-conformance] Error 2
linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 2 years ago

Welcome @pmalek!

It looks like this is your first PR to kubernetes-sigs/ingress-controller-conformance 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/ingress-controller-conformance has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 years ago

Hi @pmalek. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pmalek commented 1 year ago

/remove-lifecycle stale

bowei commented 1 year ago

/ok-to-test

bowei commented 1 year ago

/lgtm /approve

bowei commented 1 year ago

/ok-to-test

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, pmalek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment