search

kubernetes-sigs / ingress-controller-conformance

Repository for a compliance specification of ingress-controllers.
Apache License 2.0
43 stars 36 forks source link

echoserver: fix image substitution #97

Closed howardjohn closed 1 year ago

howardjohn commented 1 year ago

This should fix it once and for all, I hope. I had previously only partially copied other examples; now we are identical (https://cs.github.com/ameukam/test-infra/blob/c75172ede6fd1f1d7e42ab1fd37783a5c34c4c3b/images/alpine/cloudbuild.yaml?q=%2Fbuildx-entrypoint, https://cs.github.com/kubernetes-sigs/aws-iam-authenticator/blob/538f7f4314efd21c6f5deeb8ba7598822b89c949/cloudbuild.yaml?q=%2Fbuildx-entrypoint).

The issue was $REGISTRY refers to cloudbuild args. We could use $$REGISTRY (or hardcode), but the common pattern is to just use $PROJECT_ID which I verified in the Prow config is correctly set to k8s-staging-ingressconformance.

howardjohn commented 1 year ago

/hold

howardjohn commented 1 year ago

/hold-cancel

bowei commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, howardjohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/ingress-controller-conformance/blob/master/OWNERS)~~ [bowei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
howardjohn commented 1 year ago

/hold cancel