search

kubernetes-sigs / ip-masq-agent

Manage IP masquerade on nodes
Apache License 2.0
217 stars 70 forks source link

Log generated iptables rules too in addition to the original config file #164

Closed jingyuanliang closed 1 day ago

jingyuanliang commented 2 days ago

We now have many toggles to adjust the rules. Having them dumped in logs helps debugging and eliminates the need to inspect nodes in many cases.

/assign @MrHohn

jingyuanliang commented 1 day ago

Ha I just saw the complaint in Azure-forked ip-masq-agent (looks like they added logging earlier): https://github.com/Azure/ip-masq-agent-v2/issues/39

k8s-ci-robot commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyuanliang, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/ip-masq-agent/blob/master/OWNERS)~~ [MrHohn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment