Closed negz closed 6 years ago
Thanks for fixing this @MrHohn! Would you be able to cut a new release of ip-masq-agent with your recent fixes?
@negz Acked, I should be able to cut a new release in couple days.
@negz k8s.gcr.io/ip-masq-agent-amd64:v2.2.0
have been published. Can you check if that works for you? Thanks.
https://github.com/kubernetes-incubator/ip-masq-agent/blob/480a627/cmd/ip-masq-agent/ip-masq-agent.go#L117
It seems like
ip-masq-agent
is designed to exit non zero when any error occurs. For example without #22ip-masq-agent
often crashes on busy nodes with an obtuseiptables-restore
error. With #22 it will crash if it can't get the iptables lock:Other tools such as
kube-proxy
seem to log about this and move on with their lives. Isip-masq-agent
designed to crash and restart; i.e. should we consider frequentip-masq-agent
container restarts normal behaviour? I'm wondering whether I should attempt to 'fix'ip-masq-agent
or simply not alert when it restarts too frequently.