Closed BenTheElder closed 5 years ago
This pattern is borrowed from other Kubernetes Images: https://cs.k8s.io/?q=DOCKER_CLI_EXPERIMENTAL&i=nope&files=&repos=
In this case I referenced https://github.com/kubernetes/dns/blob/master/images/dnsmasq/Makefile which has a very similar Makefile to this repo.
cc @aojea
If this change is accepted, we can follow-up with s/-amd64//
in ip-masq-agent.yaml
once a new image is pushed.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: BenTheElder, MrHohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This will allow the ip-masq-agent DaemonSet to work on any arch out of the box (in a follow-up PR) by using a multi-arch image (manifest list).
We're planning to use the agent for http://github.com/kubernetes-sigs/kind and nominally support ADM64, ARM64 and PPCLE64 for testing, this change will make using the agent simpler.
An example is at:
gcr.io/bentheelder-kind-dev/ip-masq-agent:v2.3.0-1-g51408b3
, produced withmake all-push REGISTRY=gcr.io/bentheelder-kind-dev
./cc @MrHohn