search

kubernetes-sigs / ip-masq-agent

Manage IP masquerade on nodes
Apache License 2.0
217 stars 70 forks source link

push a multi-arch image #36

Closed BenTheElder closed 5 years ago

BenTheElder commented 5 years ago

This will allow the ip-masq-agent DaemonSet to work on any arch out of the box (in a follow-up PR) by using a multi-arch image (manifest list).

We're planning to use the agent for http://github.com/kubernetes-sigs/kind and nominally support ADM64, ARM64 and PPCLE64 for testing, this change will make using the agent simpler.

An example is at: gcr.io/bentheelder-kind-dev/ip-masq-agent:v2.3.0-1-g51408b3, produced with make all-push REGISTRY=gcr.io/bentheelder-kind-dev.

/cc @MrHohn

BenTheElder commented 5 years ago

This pattern is borrowed from other Kubernetes Images: https://cs.k8s.io/?q=DOCKER_CLI_EXPERIMENTAL&i=nope&files=&repos=

In this case I referenced https://github.com/kubernetes/dns/blob/master/images/dnsmasq/Makefile which has a very similar Makefile to this repo.

cc @aojea

BenTheElder commented 5 years ago

If this change is accepted, we can follow-up with s/-amd64// in ip-masq-agent.yaml once a new image is pushed.

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-incubator/ip-masq-agent/blob/master/OWNERS)~~ [MrHohn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment