search

kubernetes-sigs / ip-masq-agent

Manage IP masquerade on nodes
Apache License 2.0
217 stars 70 forks source link

Always --pull during docker build #6

Closed ixdy closed 7 years ago

ixdy commented 7 years ago

Without --pull, it's possible to use old base images which may have fixed vulnerabilities upstream.

x-ref kubernetes/kubernetes#47386

After merging this, we should probably create a new tag and then rebuild the image.

dnardo commented 7 years ago

/assign

dnardo commented 7 years ago

/lgtm

ixdy commented 7 years ago

@dnardo can you merge and then possibly publish a new git tag (and build a new release)? I don't have write access on this repo.

ixdy commented 7 years ago

also updated so we pull the build image; this way we'll get the latest 1.7 go patch release too.

dnardo commented 7 years ago

@ixdy done and v2.0.2 is now built.

ixdy commented 7 years ago

@dnardo where? I don't see a v2.0.2 tag in git or on gcr.io.

(also, a fix for CVE-2017-9526 just went into debian-iptables-amd64:v7, so it's good that you haven't published anything anywhere yet. if you do push an image, please be sure to rebuild first.)

dnardo commented 7 years ago

That is because I don't permission to push to gcr. I hadn't notice that last night when I pushed it. Let me see if I can get someone to push the new image up.

dnardo commented 7 years ago

Ok done. Really :-)