Closed morpheu closed 2 years ago
Welcome @morpheu!
It looks like this is your first PR to kubernetes-sigs/ip-masq-agent 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/ip-masq-agent has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: morpheu
To complete the pull request process, please assign mtaufen after the PR has been reviewed.
You can assign the PR to them by writing /assign @mtaufen
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/cc @sdmodi
@MrHohn: GitHub didn't allow me to request PR reviews from the following users: sdmodi.
Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.
It is slightly surprising that this isn't a clear longest prefix match. What happens in the following scenario nonMasqueradeCIDRs: []string{ "10.0.0.0/8", "10.0.0.0/20",}, MasqueradeExceptionCIDRS: []string{ "10.0.0.0/16", "10.0.0.0/24"}, With this implementation I believe that the non masquerading of everything in 10.0.0.0/20 except 10.0.0.0/24 will not take effect. This is precisely why we do not have exceptions implemented today.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/reopen
/remove-lifecycle rotten
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
This PR adds functionality to allow masquerade small ranges exception in large non-masquerade CIDRs. Eg: do not masquerade 10.0.0.0/8, but masquerade sub range 10.20.20.0/24