kubernetes-sigs / ip-masq-agent

Manage IP masquerade on nodes
Apache License 2.0
217 stars 70 forks source link

add CidrLimit configuration variable #93

Closed stonith closed 1 year ago

stonith commented 1 year ago

supercedes #91

k8s-ci-robot commented 1 year ago

@MrHohn: GitHub didn't allow me to request PR reviews from the following users: jingyuanliang.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/ip-masq-agent/pull/93#pullrequestreview-1207135447): >Thanks @stonith ! I like this approach better to allow for more flexibility. > >One minor request - could you update also https://github.com/kubernetes-sigs/ip-masq-agent/blob/master/agent-config/config to show case this new field? Thanks! > >/cc @jingyuanliang Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
stonith commented 1 year ago

Thanks @stonith ! I like this approach better to allow for more flexibility.

One minor request - could you update also https://github.com/kubernetes-sigs/ip-masq-agent/blob/master/agent-config/config to show case this new field? Thanks!

/cc @jingyuanliang

Done, also updated the README.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, stonith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/ip-masq-agent/blob/master/OWNERS)~~ [MrHohn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment