Closed danielvegamyhre closed 1 year ago
/assign
@ahg-g I listed the main features in the changelog above, anything you want to add?
Default using internal cert: user can use cert-manager as second choice
do we need to specify this? if not, please ignore this comment
thanks @charles-chenzz, I added this to the changelog
- Webhook uses internal cert by default; user can use cert-manager as second choice
I made some edits to the first bullet.
Webhook uses internal cert by default; user can use cert-manager as second choice
How can they use cert-manager? if this is possible, please lets add it to the documentation.
@ahg-g They would need to install cert-manager on their cluster with kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.11.0/cert-manager.yaml
then update this line in the config yaml to say ../components/certmanager
, then uncomment all the sections beginning with [CERTMANAGER]
. Perhaps we shouldn't explicitly support this? Seems kind of hacky to me, I would be in favor of removing cert manager altogether in the future unless there is some benefit to keeping it.
I think for security reasons, some organizations will want to use cert-manager since it implements cert rotation
I think for security reasons, some organizations will want to use cert-manager since it implements cert rotation
Agree. In production env, such as running both serving (prediction) and training for ML Apps, we often manage many certs by the cert-manager. In that case, we would prefer to handle all certs (including certs for the webhook) by the cert-manager.
I see, that makes sense. I created tracking issue #105 for the relevant documentation updates.
Successfully pulled registry.k8s.io/jobset/jobset:v0.1.0
with docker.
Successfully pulled
registry.k8s.io/jobset/jobset:v0.1.0
with docker.
I confirmed that the image can be pulled.
$ docker pull registry.k8s.io/jobset/jobset:v0.1.0
v0.1.0: Pulling from jobset/jobset
a7ca0d9ba68f: Pull complete
fe5ca62666f0: Pull complete
b02a7525f878: Pull complete
fcb6f6d2c998: Pull complete
e8c73c638ae9: Pull complete
1e3d9b7d1452: Pull complete
4aa0ea1413d3: Pull complete
7c881f9ab25e: Pull complete
5627a970d25e: Pull complete
03e20a23062b: Pull complete
Digest: sha256:bab26f4d7f550f0b9afe92192cfb4751e3706a5ca6159f67ca93119b81221954
Status: Downloaded newer image for registry.k8s.io/jobset/jobset:v0.1.0
registry.k8s.io/jobset/jobset:v0.1.0
$ docker image inspect registry.k8s.io/jobset/jobset:v0.1.0 | jq '.[].RepoDigests'
[
"registry.k8s.io/jobset/jobset@sha256:bab26f4d7f550f0b9afe92192cfb4751e3706a5ca6159f67ca93119b81221954"
]
/lgtm
Release v0.1.0 published: https://github.com/kubernetes-sigs/jobset/releases/tag/v0.1.0
Announcement email link: https://groups.google.com/a/kubernetes.io/g/wg-batch/c/cjZ3ZmiptQ8
Release Checklist
git branch release-$MAJ.$MIN main
git push release-$MAJ.$MIN
make artifacts IMAGE_REGISTRY=registry.k8s.io/jobset GIT_TAG=$VERSION
to generate the artifacts and upload the files in theartifacts
folder to the draft release.git tag -s $VERSION
and inserts the changelog into the tag description. To perform this step, you need a PGP key registered on github.git push $VERSION
gcr.io/k8s-staging-jobset/jobset:$VERSION
k8s.gcr.io/images/k8s-staging-jobset/images.yaml
to promote the container images to production:registry.k8s.io/jobset/jobset:$VERSION
is available.sig-apps@kubernetes.io
,sig-scheduling@kubernetes.io
andwg-batch@kubernetes.io
with the subject[ANNOUNCE] JobSet $VERSION is released
README.md
anddocs/setup/install.md
inmain
branch:main
branch, on the first commit that gets merged after the release branch has been created (presumably the README update commit above), and, push the tag:DEVEL=v0.$(($MAJ+1)).0-devel; git tag $DEVEL main && git push $DEVEL
This ensures that the devel builds on themain
branch will have a meaningful version number.Changelog