kubernetes-sigs / jobset

JobSet: a k8s native API for distributed ML training and HPC workloads
https://jobset.sigs.k8s.io/
Apache License 2.0
140 stars 46 forks source link

Release v0.1.0 #100

Closed danielvegamyhre closed 1 year ago

danielvegamyhre commented 1 year ago

Release Checklist

Changelog

danielvegamyhre commented 1 year ago

/assign

danielvegamyhre commented 1 year ago

@ahg-g I listed the main features in the changelog above, anything you want to add?

charles-chenzz commented 1 year ago

Default using internal cert: user can use cert-manager as second choice do we need to specify this? if not, please ignore this comment

danielvegamyhre commented 1 year ago

thanks @charles-chenzz, I added this to the changelog

ahg-g commented 1 year ago
  • Webhook uses internal cert by default; user can use cert-manager as second choice

I made some edits to the first bullet.

Webhook uses internal cert by default; user can use cert-manager as second choice

How can they use cert-manager? if this is possible, please lets add it to the documentation.

danielvegamyhre commented 1 year ago

@ahg-g They would need to install cert-manager on their cluster with kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.11.0/cert-manager.yaml then update this line in the config yaml to say ../components/certmanager, then uncomment all the sections beginning with [CERTMANAGER]. Perhaps we shouldn't explicitly support this? Seems kind of hacky to me, I would be in favor of removing cert manager altogether in the future unless there is some benefit to keeping it.

ahg-g commented 1 year ago

I think for security reasons, some organizations will want to use cert-manager since it implements cert rotation

tenzen-y commented 1 year ago

I think for security reasons, some organizations will want to use cert-manager since it implements cert rotation

Agree. In production env, such as running both serving (prediction) and training for ML Apps, we often manage many certs by the cert-manager. In that case, we would prefer to handle all certs (including certs for the webhook) by the cert-manager.

danielvegamyhre commented 1 year ago

I see, that makes sense. I created tracking issue #105 for the relevant documentation updates.

danielvegamyhre commented 1 year ago

Successfully pulled registry.k8s.io/jobset/jobset:v0.1.0 with docker.

tenzen-y commented 1 year ago

Successfully pulled registry.k8s.io/jobset/jobset:v0.1.0 with docker.

I confirmed that the image can be pulled.

$ docker pull registry.k8s.io/jobset/jobset:v0.1.0
v0.1.0: Pulling from jobset/jobset
a7ca0d9ba68f: Pull complete 
fe5ca62666f0: Pull complete 
b02a7525f878: Pull complete 
fcb6f6d2c998: Pull complete 
e8c73c638ae9: Pull complete 
1e3d9b7d1452: Pull complete 
4aa0ea1413d3: Pull complete 
7c881f9ab25e: Pull complete 
5627a970d25e: Pull complete 
03e20a23062b: Pull complete 
Digest: sha256:bab26f4d7f550f0b9afe92192cfb4751e3706a5ca6159f67ca93119b81221954
Status: Downloaded newer image for registry.k8s.io/jobset/jobset:v0.1.0
registry.k8s.io/jobset/jobset:v0.1.0
$ docker image inspect registry.k8s.io/jobset/jobset:v0.1.0 | jq '.[].RepoDigests'
[
  "registry.k8s.io/jobset/jobset@sha256:bab26f4d7f550f0b9afe92192cfb4751e3706a5ca6159f67ca93119b81221954"
]
ahg-g commented 1 year ago

/lgtm

danielvegamyhre commented 1 year ago

Release v0.1.0 published: https://github.com/kubernetes-sigs/jobset/releases/tag/v0.1.0

danielvegamyhre commented 1 year ago

Announcement email link: https://groups.google.com/a/kubernetes.io/g/wg-batch/c/cjZ3ZmiptQ8