kubernetes-sigs / karpenter

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
Apache License 2.0
522 stars 170 forks source link

Migrate Ginkgo Expectations to operatorpkg #1348

Open jonathan-innis opened 2 months ago

jonathan-innis commented 2 months ago

Description

What problem are you trying to solve?

Right now, we have a bunch of duplicates for "expectations" for Ginkgo testing that are already present in operatorpkg. We should be able to just do a once-off migration over to it and drop all of these exepctations from our codebase.

See: https://github.com/awslabs/operatorpkg/blob/main/test/expectations/expectations.go

k8s-ci-robot commented 2 months ago

This issue is currently awaiting triage.

If Karpenter contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.