kubernetes-sigs / karpenter

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
Apache License 2.0
546 stars 183 forks source link

Enable automated cherry-picks for karpenter #1543

Open liangyuanpeng opened 1 month ago

liangyuanpeng commented 1 month ago

Description

What problem are you trying to solve?

I can see that there are some PR for backport, and i believe that the cherrypick plugin will simplify this process, just only need to comment /cherry-pick release-v0.37.x at origin PR and then the bot will create a PR for release-v0.37.x, see cluster api project how to use it: https://github.com/kubernetes-sigs/cluster-api/pull/10988#issuecomment-2264968211

Before I open a PR at test-infra to enable plugin for karpenter I hope we can reach a consensus.

/assign /cc @engedaam @jonathan-innis

How important is this feature to you?

k8s-ci-robot commented 1 month ago

This issue is currently awaiting triage.

If Karpenter contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
njtran commented 1 month ago

Is this purely to do automated cherry-picks? This seems interesting! We've done most of our cherry-picks for this upcoming release, but definitely interested to see how this works.

liangyuanpeng commented 1 month ago

Is this purely to do automated cherry-picks?

exactly!

Basically, it is a cherry pick plugin owned by the Kubernetes community, i will open a PR at https://github.com/kubernetes/test-infra to enable cherry pick pligun for karpenter, and then need the karpenter maintainer LGTMs and approves the PR. Then I will look for the test-infra lead to merge the PR.

Once the cherrypick plugin is enabled for the karpenter repo, you can ask the bot to open a backport PR for the release-v0.37.x branch by commenting /cherry-pick release-v0.37.x on the original PR