kubernetes-sigs / karpenter

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
Apache License 2.0
614 stars 203 forks source link

Labels and taints are missing on the nodes that karpenter node pools bring up #1634

Open janani2019 opened 2 months ago

janani2019 commented 2 months ago

Description

Observed Behavior: When I do a describe node on any of the nodes that the karpenter nodepool brings up, I expect to see the taints and labels applied. Expected Behavior: The taints and labels are not applied Reproduction Steps (Please include YAML): apiVersion: karpenter.sh/v1 kind: NodePool metadata: name: imagebuild spec: template: metadata: labels: type: ImageBuilder spec: expireAfter: 19m terminationGracePeriod: 20m requirements:

Versions:

k8s-ci-robot commented 2 months ago

This issue is currently awaiting triage.

If Karpenter contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
engedaam commented 1 month ago

Are the labels present on nodeclaimtemplatespec? https://karpenter.sh/docs/concepts/nodepools/#spectemplatemetadatalabels. Seem like the labels are on the nodepool metadata. Can you share a node that is owned by the nodepool and does not contain the taint specified?