search

kubernetes-sigs / karpenter

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
Apache License 2.0
637 stars 206 forks source link

fix: correct error type for NodeClaim helpers #1739

Closed jmdeal closed 1 month ago

jmdeal commented 1 month ago

Fixes #N/A

Description This corrects the error type returned for the NodeClaimForNode utility function. Additionally, corrects some of the comments. The only reference to this utility function already correctly handled both error types so no update is needed there. https://github.com/kubernetes-sigs/karpenter/blob/8101424eeecb2b6d82fe956f64136091cd6ce939/pkg/controllers/nodeclaim/podevents/controller.go#L71-L76

How was this change tested? make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11188829925

Details

Files with Coverage Reduction New Missed Lines %
pkg/scheduling/requirements.go 2 98.01%
pkg/controllers/provisioning/scheduling/nodeclaim.go 2 89.13%
pkg/utils/node/node.go 8 70.59%
<!-- Total: 12 -->
Totals Coverage Status
Change from base Build 11169601877: 0.03%
Covered Lines: 8436
Relevant Lines: 10462
💛 - Coveralls
jonathan-innis commented 1 month ago

/lgtm /approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmdeal, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/karpenter/blob/main/OWNERS)~~ [jonathan-innis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment