chore: Scope role down to needed permissions

kubernetes-sigs / karpenter

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.

Apache License 2.0

637 stars 206 forks source link

chore: Scope role down to needed permissions #1758

Closed jonathan-innis closed 1 month ago

jonathan-innis commented 1 month ago

Fixes #N/A

Description

Scope role permissions down to needed permissions. This includes dropping the CRD update permission that is no longer needed now that webhooks have been dropped.

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11393431651

Details

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.05%) to 80.93%

Files with Coverage Reduction	New Missed Lines	%
pkg/test/expectations/expectations.go	2	94.73%
<!--	Total:	2		-->

Totals
Change from base Build 11393209716:	0.05%
Covered Lines:	8492
Relevant Lines:	10493

💛 - Coveralls

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, rschalo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/karpenter/blob/main/OWNERS)~~ [jonathan-innis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jmdeal commented 1 month ago

/lgtm