Add a Drifted condition to NodePool that tells whether any nodeclaims are drifted from the desired state

[reegnz]

Description

What problem are you trying to solve?

I'm trying to integrate karpenter nodepools into argocd health checks. This would help argocd determine when a deployment of an ec2nodeclass or nodepool configuration change has been reconciled.

I think I could resolve this by writing a custom controller that adds an extra condition called Drifted to each NodePool resource, but I'd much rather have this solved natively by karpenter.

Proposal:

Introduce a new condition called Drifted with a value of False if the hashes of the NodeClaims managed by the NodePool do not match the hash of the NodePool and/or the Ec2NodeClass. The value should be True if any of the NodeClaims has a drifted hash of the NodePool or Ec2NodeClass.

Optionally there could be a status that tells how many nodeclaims we have that are drifted. If that count is 0 then the Drifted condition could be set to False.

How important is this feature to you?

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[reegnz]

Originally opened here: https://github.com/aws/karpenter-provider-aws/issues/7293

[njtran]

/triage accepted