kubernetes-sigs / karpenter

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
Apache License 2.0
637 stars 206 forks source link

feat: add instance type drift for instance types that are no longer discoverable #1787

Closed njtran closed 1 week ago

njtran commented 3 weeks ago

Fixes #N/A

Description For instance types that are deprecated, AWS cloud provider doesn't include those instance types. We want to make sure that we can still drift these instances since the absence of the instance type implies that it's not compatible with the NodePool requirements.

How was this change tested? make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 11748274434

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclaim/disruption/drift.go 13 15 86.67%
<!-- Total: 35 37 94.59% -->
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/consolidation.go 4 88.55%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 11747362633: 0.04%
Covered Lines: 8536
Relevant Lines: 10543

💛 - Coveralls
k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/karpenter/blob/main/OWNERS)~~ [jonathan-innis,njtran] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment