Closed njtran closed 1 week ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pkg/controllers/nodeclaim/disruption/drift.go | 13 | 15 | 86.67% | ||
<!-- | Total: | 35 | 37 | 94.59% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pkg/controllers/disruption/consolidation.go | 4 | 88.55% | ||
<!-- | Total: | 4 | --> |
Totals | |
---|---|
Change from base Build 11747362633: | 0.04% |
Covered Lines: | 8536 |
Relevant Lines: | 10543 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jonathan-innis, njtran
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Fixes #N/A
Description For instance types that are deprecated, AWS cloud provider doesn't include those instance types. We want to make sure that we can still drift these instances since the absence of the instance type implies that it's not compatible with the NodePool requirements.
How was this change tested? make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.