kubernetes-sigs / karpenter

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
Apache License 2.0
637 stars 206 forks source link

feat: add log for scheduling progress for long running scheduling sim… #1788

Closed njtran closed 3 weeks ago

njtran commented 3 weeks ago

…ulations

Fixes #N/A

Description This adds a log in case provisioning takes too long, and the user wants to know if scheduling is occurring

How was this change tested? locally

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 11598853956

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 1 0.0%
pkg/controllers/provisioning/scheduling/scheduler.go 7 10 70.0%
<!-- Total: 9 13 69.23% -->
Totals Coverage Status
Change from base Build 11584810194: 0.1%
Covered Lines: 8498
Relevant Lines: 10502

💛 - Coveralls
k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/karpenter/blob/main/OWNERS)~~ [jonathan-innis,njtran] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment