coveralls
commented
3 weeks ago Pull Request Test Coverage Report for Build 11619365060
Details
- 7 of 9 (77.78%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.08%) to 80.944%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| pkg/controllers/nodeclaim/expiration/controller.go | 7 | 9 | 77.78% | ||
| <!-- | Total: | 7 | 9 | 77.78% | --> |
| Totals | |
|---|---|
| Change from base Build 11603073442: | 0.08% |
| Covered Lines: | 8508 |
| Relevant Lines: | 10511 |
k8s-ci-robot
Fixes #N/A
Description Currently, the expiration controller reconciles against all NodeClaim updates, and doesn't have a check to ensure that the NodeClaim hasn't already been terminated. This can result in duplicate expiration attempts against the same NodeClaim. The main problem with this (other than unnecessary deletes) is that we increment the expiration metric each time.
This change ensures we don't double count expirations through two mechanisms: a. Check that the NodeClaim's deletion timestamp is zero before proceeding with expiration. b. Only enqueue requests for NodeClaims when they are first added to the informer cache.
How was this change tested?
make testBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.