Closed jonathan-innis closed 1 week ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jonathan-innis
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pkg/controllers/disruption/multinodeconsolidation.go | 0 | 1 | 0.0% | ||
pkg/controllers/disruption/singlenodeconsolidation.go | 0 | 1 | 0.0% | ||
pkg/cloudprovider/metrics/cloudprovider.go | 0 | 14 | 0.0% | ||
<!-- | Total: | 110 | 126 | 87.3% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pkg/controllers/provisioning/scheduling/preferences.go | 7 | 86.67% | ||
<!-- | Total: | 7 | --> |
Totals | |
---|---|
Change from base Build 11747362633: | -0.1% |
Covered Lines: | 8453 |
Relevant Lines: | 10463 |
Fixes #N/A
Description
This leverages https://github.com/awslabs/operatorpkg/pull/92 to create abstract metrics so that you can create an arbitrary pipeline for routing metrics beyond prometheus
For instance,
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.