chore: create new error type to wrap message and error

kubernetes-sigs / karpenter

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.

Apache License 2.0

637 stars 206 forks source link

chore: create new error type to wrap message and error #1811

Closed jigisha620 closed 1 week ago

jigisha620 commented 1 week ago

Fixes #N/A

Description Create a new error type that can wrap error message and actual error.

How was this change tested? NA

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

k8s-ci-robot commented 1 week ago

Hi @jigisha620. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 11847587430

Details

12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
12 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.09%) to 80.743%

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/node/termination/controller.go	2	68.59%
pkg/controllers/state/cluster.go	3	91.71%
pkg/controllers/provisioning/scheduling/preferences.go	7	86.67%
<!--	Total:	12	-->

Totals
Change from base Build 11844567802:	-0.09%
Covered Lines:	8478
Relevant Lines:	10500

💛 - Coveralls

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jigisha620, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/karpenter/blob/main/OWNERS)~~ [jonathan-innis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment