kubernetes-sigs / karpenter

Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
Apache License 2.0
641 stars 207 forks source link

chore: Limit Node Repair based by Nodepool #1831

Open engedaam opened 5 days ago

engedaam commented 5 days ago

Fixes #N/A

Description

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

k8s-ci-robot commented 5 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: engedaam Once this PR has been reviewed and has the lgtm label, please assign tzneal for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/karpenter/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 12019705547

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/node/health/controller.go 32 56 57.14%
<!-- Total: 32 56 57.14% -->
Files with Coverage Reduction New Missed Lines %
pkg/utils/termination/termination.go 2 92.31%
pkg/test/expectations/expectations.go 2 94.73%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
<!-- Total: 11 -->
Totals Coverage Status
Change from base Build 11994809568: -0.2%
Covered Lines: 8871
Relevant Lines: 10967

💛 - Coveralls
jmdeal commented 3 days ago

/lgtm

k8s-ci-robot commented 2 hours ago

New changes are detected. LGTM label has been removed.