Closed rschalo closed 14 hours ago
Hi @rschalo. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jonathan-innis, rschalo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold Testing needed for this change
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pkg/test/expectations/expectations.go | 2 | 94.73% | ||
<!-- | Total: | 2 | --> |
Totals | |
---|---|
Change from base Build 11960172117: | 0.05% |
Covered Lines: | 8746 |
Relevant Lines: | 10788 |
/unhold discussed offline, we're going to add more holistic testing in a follow-up.
/ok-to-test /hold cancel
Fixes #N/A
Description This fixes an issue where during deletion, the generation of an object is incremented and then the status condition controller we use transitions the root condition of the object to
Unknown
due to a mismatch inlastSeenGeneration
andcurrentGeneration
for other status conditions.How was this change tested? Unit tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.