search

kubernetes-sigs / kernel-module-management

The kernel module management operator builds, signs and loads kernel modules in Kubernetes clusters.
https://kmm.sigs.k8s.io/
Apache License 2.0
91 stars 26 forks source link

Changing the `ImagePullPolicy` for the operator and the webhook. #866

Closed ybettan closed 3 months ago

ybettan commented 3 months ago

For the KMM operator, the ImagePullPolicy was set to Always for development reasons but it is in fact not the best practice, therefore, it was removed to allowed kubelet to have its default pull policy.

The webhook-server's pull policy was also removed to use the default behavior to stay in sync with the KMM operator it is deployed with.

In a nutshell, the default policy is Always if the latest tag is used and IfNotPresent otherwise.

This change is expected to reduce the networking bandwidth.

/cc @yevgeny-shnaidman @TomerNewman

k8s-ci-robot commented 3 months ago

@ybettan: GitHub didn't allow me to request PR reviews from the following users: TomerNewman.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/kernel-module-management/pull/866): >For the KMM operator, the `ImagePullPolicy` was set to `Always` for development reasons but it is in fact not the best practice, therefore, it was removed to allowed `kubelet` to have its default pull policy. > >The webhook-server's pull policy was also removed to use the default behavior to stay in sync with the KMM operator it is deployed with. > >In a nutshell, the default policy is `Always` if the `latest` tag is used and `IfNotPresent` otherwise. > >This change is expected to reduce the networking bandwidth. > >--- > >/cc @yevgeny-shnaidman @TomerNewman Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kernel-module-management/blob/main/OWNERS)~~ [ybettan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 3 months ago

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
Latest commit e36aac61e297837f5051e5d90642e3c70304b432
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/66a62a57e7988700084b1cbc
Deploy Preview https://deploy-preview-866--kubernetes-sigs-kmm.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.95%. Comparing base (fa23a9b) to head (e36aac6). Report is 91 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #866 +/- ## ========================================== - Coverage 79.09% 71.95% -7.14% ========================================== Files 51 66 +15 Lines 5109 4522 -587 ========================================== - Hits 4041 3254 -787 - Misses 882 1073 +191 - Partials 186 195 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yevgeny-shnaidman commented 3 months ago

/lgtm