kubernetes-sigs / kernel-module-management

The kernel module management operator builds, signs and loads kernel modules in Kubernetes clusters.
https://kmm.sigs.k8s.io/
Apache License 2.0
87 stars 26 forks source link

Fixing some `kustomizeconfig.yaml` files. #887

Closed ybettan closed 2 weeks ago

ybettan commented 2 weeks ago

Since kustomize@v5.4.0, yaml.UnmarshalStric() is used instead of yaml.Unmarshal() which means that fields in the yamls that doesn't exist in the golang object will fail to unmarshal instead of being ignored like they would without the strict behavior.

Therefore, those redundant name fields where removed.

In addition, I have bumped kustomize@5.3.0 --> kustomize@5.4.3 to make sure we get a closer behavior on machines that comes with kustomize pre-installed and those which aren't and install it on-the-fly.

--

/assign @yevgeny-shnaidman This PR is blocking a bunch of other PRs like:

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kernel-module-management/blob/main/OWNERS)~~ [ybettan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 2 weeks ago

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
Latest commit 5d62cc611684dbfb9d28835e4d935396e4f2c00c
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/66cdf9e641826d0009bf61eb
Deploy Preview https://deploy-preview-887--kubernetes-sigs-kmm.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yevgeny-shnaidman commented 2 weeks ago

/lgtm