wherka-ama
commented
2 years ago Here is the patch that I was referring to in the description:
diff --git a/pkg/cluster/internal/providers/docker/provision.go b/pkg/cluster/internal/providers/docker/provision.go
index 97b05594..aab4a3f4 100644
--- a/pkg/cluster/internal/providers/docker/provision.go
+++ b/pkg/cluster/internal/providers/docker/provision.go
@@ -286,12 +286,12 @@ func getProxyEnv(cfg *config.Cluster, networkName string, nodeNames []string) (m
noProxyList := append(subnets, envs[common.NOProxy])
noProxyList = append(noProxyList, nodeNames...)
- // Add pod and service dns names to no_proxy to allow in cluster
+ // Add pod, service and control plane(API server) dns names to no_proxy to allow in cluster
// Note: this is best effort based on the default CoreDNS spec
// https://github.com/kubernetes/dns/blob/master/docs/specification.md
// Any user created pod/service hostnames, namespaces, custom DNS services
// are expected to be no-proxied by the user explicitly.
- noProxyList = append(noProxyList, ".svc", ".svc.cluster", ".svc.cluster.local")
+ noProxyList = append(noProxyList, ".svc", ".svc.cluster", ".svc.cluster.local", strings.Join([]string{cfg.Name, "control-plane"}, "-"))
noProxyJoined := strings.Join(noProxyList, ",")
envs[common.NOProxy] = noProxyJoined
envs[strings.ToLower(common.NOProxy)] = noProxyJoined
diff --git a/pkg/cluster/internal/providers/podman/provision.go b/pkg/cluster/internal/providers/podman/provision.go
index a515324e..68c1a2a0 100644
--- a/pkg/cluster/internal/providers/podman/provision.go
+++ b/pkg/cluster/internal/providers/podman/provision.go
@@ -252,12 +252,12 @@ func getProxyEnv(cfg *config.Cluster, networkName string) (map[string]string, er
return nil, err
}
noProxyList := append(subnets, envs[common.NOProxy])
- // Add pod and service dns names to no_proxy to allow in cluster
+ // Add pod, service and control plane(API server) dns names to no_proxy to allow in cluster
// Note: this is best effort based on the default CoreDNS spec
// https://github.com/kubernetes/dns/blob/master/docs/specification.md
// Any user created pod/service hostnames, namespaces, custom DNS services
// are expected to be no-proxied by the user explicitly.
- noProxyList = append(noProxyList, ".svc", ".svc.cluster", ".svc.cluster.local")
+ noProxyList = append(noProxyList, ".svc", ".svc.cluster", ".svc.cluster.local", strings.Join([]string{cfg.Name, "con
trol-plane"}, "-"))
noProxyJoined := strings.Join(noProxyList, ",")
envs[common.NOProxy] = noProxyJoined
envs[strings.ToLower(common.NOProxy)] = noProxyJoinedI can create a PR as well if that's a preferred way of solving this problem relatively quickly.
aojea
k8s-ci-robot
What happened: Kind failed to create the cluster in the environment with http(s) proxy
What you expected to happen: Successful cluster creation
How to reproduce it (as minimally and precisely as possible): 1.Setup or use an existing http(s) - in this context we used squid/4.15 2.Set the env variables: https_proxy and http_proxy to point at the proxy above
Anything else we need to know?: I've done some extra troubleshooting to recreate the API server health checks done during the cluster boot:
I've already modified the podman.getProxyEnv in order to add
<cluster name>-control-planeto no_proxy to improve the situation. After the patch everything worked as expected. I'm happy to propose such implementation as a PR.Environment:
kind version: (use
kind version): 0.14.0Kubernetes version: (use
kubectl version): Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.3", GitCommit:"aef86a93758dc3cb2c658dd9657ab4ad4afc21cb", GitTreeState:"clean", BuildDate:"2022-07-13T14:30:46Z", GoVersion:"go1.18.3", Compiler:"gc", Platform:"linux/amd64"} Kustomize Version: v4.5.4 Unable to connect to the server: dial tcp 10.xxx:443: i/o timeoutDocker version: (use
docker info):OS (e.g. from
/etc/os-release):