search

kubernetes-sigs / kind

Kubernetes IN Docker - local clusters for testing Kubernetes
https://kind.sigs.k8s.io/
Apache License 2.0
13.41k stars 1.55k forks source link

CI: should we need switch ubuntu-22.04 for cgroup v2 test env? #3020

Closed tao12345666333 closed 1 year ago

tao12345666333 commented 1 year ago

What should be cleaned up or changed:

GitHub Action has provided ubuntu-22.04 as the default operating environment.

ubuntu-22.04 already uses cgroups v2 by default, do we want to switch the current cgroup v2 test to use ubuntu-22.04?

xref:

Why is this needed:

No longer depends on Vagrant's nesting, maybe faster (but need to verify)

tao12345666333 commented 1 year ago

cc @AkihiroSuda

AkihiroSuda commented 1 year ago

The vagrant test uses Fedora to cover several SELinux-related quirks, such as

So I'd prefer to retain the vagrant tests.

AkihiroSuda commented 1 year ago

(Off-topic: Cirrus CI might be faster than GHA for running Vagrant)

aojea commented 1 year ago

+1 to keep Fedora on the CI, it has been a good signal for podman, selinux, btrfs, cgroupsv2, ... any thing that is more bleeding edge that more stable distros

tao12345666333 commented 1 year ago

make sense.

Let's keep it. Thanks!

/close

k8s-ci-robot commented 1 year ago

@tao12345666333: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/kind/issues/3020#issuecomment-1350231184): >make sense. > >Let's keep it. Thanks! > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
BenTheElder commented 1 year ago

We'll want to keep testing cgroups v1 for now unfortunately, the migration to v2 only is going to be challenging for this project. Even if we switch, I agree that we still want to test the fedora environment, where we've encountered many quirks we're likely to run into with end users in the same or similar environments.