search

kubernetes-sigs / kind

Kubernetes IN Docker - local clusters for testing Kubernetes
https://kind.sigs.k8s.io/
Apache License 2.0
13.02k stars 1.51k forks source link

fix kind version unit test failures for released versions #3599

Closed hp685 closed 2 months ago

hp685 commented 2 months ago

Version() string assumes that preRelease version is set for commit hash and count to be taken into account. Update the unit tests to pass in a pre release version per test case

k8s-ci-robot commented 2 months ago

Welcome @hp685!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 months ago

Hi @hp685. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
BenTheElder commented 2 months ago

fix kind version unit test failures on non-main branches

We don't have or support any branch other than main ...?

Can you explain in more detail what you're attempting to fix?

hp685 commented 2 months ago

fix kind version unit test failures on non-main branches

We don't have or support any branch other than main ...?

Can you explain in more detail what you're attempting to fix?

Updated the title. Here's what I meant:

the version unit tests fail for any released artifacts since the versionPreRelease is "" after the release. Any downstreams that rely on building and testing a released version would encounter this failure

BenTheElder commented 2 months ago

Ah -- That's an interesting gap. Our release process creates a new pre-release commit immediately following the release tag commit so we're never testing that commit alone.

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, hp685

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kind/blob/main/OWNERS)~~ [BenTheElder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 2 months ago

@hp685: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kind-e2e-kubernetes-1-29 4b69508cafd55e84c6a965a6a1b90a239a8ab982 link true /test pull-kind-e2e-kubernetes-1-29
pull-kind-e2e-kubernetes-1-28 4b69508cafd55e84c6a965a6a1b90a239a8ab982 link true /test pull-kind-e2e-kubernetes-1-28

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
hp685 commented 2 months ago

/retest

k8s-ci-robot commented 2 months ago

@hp685: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubernetes-sigs/kind/pull/3599#issuecomment-2089251377): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
hp685 commented 2 months ago

Looking at the logs for the e2e jobs the timeout failure doesn't seem relevant to this change

BenTheElder commented 2 months ago

correct