search

kubernetes-sigs / kind

Kubernetes IN Docker - local clusters for testing Kubernetes
https://kind.sigs.k8s.io/
Apache License 2.0
13.01k stars 1.51k forks source link

update pause image to 3.10 #3627

Closed bzsuni closed 4 weeks ago

bzsuni commented 1 month ago

start using registry.k8s.io/pause:3.10

k8s-ci-robot commented 1 month ago

Welcome @bzsuni!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 month ago

Hi @bzsuni. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
bzsuni commented 1 month ago

ref https://github.com/kubernetes/kubernetes/issues/125092

neolit123 commented 1 month ago

/ok-to-test

stmcginnis commented 1 month ago

/lgtm

BenTheElder commented 1 month ago

FWIW we've not been bumping this because all of the changes since ... 3.3? 3.6? have been windows-only and kind nodes do not run on windows.

I am still +1 to update though, pending dropping the unrelated test-data change (it's harmless, but we don't want to keep churning this every time and it's a bad sign if the tests fail when we change the real file)

stmcginnis commented 1 month ago

/lgtm

Took a little closer look since it sounds like updating isn't strictly necessary. The last time the Linux pause source was changed was ~4 years ago, and newer updates to the container image have all been for Windows. That said, it looks like something is overlooked if we don't keep this at least somewhat updated. There's a 10K difference in size, so not much harm there.

k8s-ci-robot commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, bzsuni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kind/blob/main/OWNERS)~~ [BenTheElder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment