kubernetes-sigs / kind

Kubernetes IN Docker - local clusters for testing Kubernetes
https://kind.sigs.k8s.io/
Apache License 2.0
13.01k stars 1.51k forks source link

[rebased #3360] cluster: drop DisableLocalStorageCapacityIsolation #3651

Closed BenTheElder closed 3 weeks ago

BenTheElder commented 3 weeks ago

Rebased https://github.com/kubernetes-sigs/kind/pull/3360, original description below:

it was used to workaround a kubelet crash issue with rootless providers.

The Kubelet seems to work fine now with localStorageCapacityIsolation enabled in a user namespace so drop the special handling. After this change, ephemeral storage can be used in a rootless cluster.

Closes: https://github.com/kubernetes-sigs/kind/issues/3359

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kind/blob/main/OWNERS)~~ [BenTheElder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aojea commented 3 weeks ago

all fedora jobs failed?

BenTheElder commented 3 weeks ago

There was a flake SSH-ing to the VM in each of them, doesn't seem related.

BenTheElder commented 3 weeks ago

it never even ran kind in this flake https://github.com/kubernetes-sigs/kind/actions/runs/9457245522/job/26088691929#step:7:22

failed during rootless setup

BenTheElder commented 3 weeks ago

I'd like all the CI to pass here ideally before merge.

I don't think the issue is with these changes though so we should probably debug elsewhere.

https://github.com/kubernetes-sigs/kind/pull/648 will run these without changes

BenTheElder commented 3 weeks ago

Rebased again after #3653

BenTheElder commented 3 weeks ago

All tests passing now.

aojea commented 3 weeks ago

/lgtm