search

kubernetes-sigs / kind

Kubernetes IN Docker - local clusters for testing Kubernetes
https://kind.sigs.k8s.io/
Apache License 2.0
13.01k stars 1.51k forks source link

switch to currently supported fedora #3654

Closed BenTheElder closed 1 week ago

BenTheElder commented 3 weeks ago

~stop hardcoding exact download~

xref https://github.com/kubernetes-sigs/kind/pull/3653

/hold

TODO: figure out why fedora 40 isn't working

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kind/blob/main/OWNERS)~~ [BenTheElder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stmcginnis commented 3 weeks ago

3653 is good, but I kind of think it might be good to just make the bigger jump while we're at it.

/lgtm

BenTheElder commented 3 weeks ago

/override pull-kind-e2e-kubernetes-1-29

pod scheduling timeout in prow is not great but also not relevant to this PR

k8s-ci-robot commented 3 weeks ago

@BenTheElder: Overrode contexts on behalf of BenTheElder: pull-kind-e2e-kubernetes-1-29

In response to [this](https://github.com/kubernetes-sigs/kind/pull/3654#issuecomment-2161468256): >/override pull-kind-e2e-kubernetes-1-29 > >pod scheduling timeout in prow is not great but also not relevant to this PR Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
BenTheElder commented 3 weeks ago

This change isn't working yet.

BenTheElder commented 3 weeks ago

Looks like Fedora 39 works. It's still supported but 40 would be more current.

It also looks like the downloads are slow and we should switch back to downloading from a mirror.

stmcginnis commented 2 weeks ago

Just capturing failure message here for convenience and in case we lose the job logs.

Pod "pfpod2" is invalid: [spec.containers[0].resources.requests: Invalid value: "600m": must be less than or equal to cpu limit of 500m, spec.containers[0].resources.requests: Invalid value: "600Gi": must be less than or equal to ephemeral-storage limit of 500Gi, spec.containers[0].resources.requests: Invalid value: "600Mi": must be less than or equal to memory limit of 500Mi]
BenTheElder commented 2 weeks ago

So that's a bug in the upstream tests and we should file an issue there, it's defintiely not related to this PR which only affects some of the github actions.

BenTheElder commented 1 week ago

/override pull-kind-e2e-kubernetes-1-26 pull-kind-e2e-kubernetes-1-27

(prow e2e not relevant for this change)

k8s-ci-robot commented 1 week ago

@BenTheElder: Overrode contexts on behalf of BenTheElder: pull-kind-e2e-kubernetes-1-26, pull-kind-e2e-kubernetes-1-27

In response to [this](https://github.com/kubernetes-sigs/kind/pull/3654#issuecomment-2181624530): >/override pull-kind-e2e-kubernetes-1-26 pull-kind-e2e-kubernetes-1-27 > >(prow e2e not relevant for this change) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
BenTheElder commented 1 week ago

actions are passing, I lost context and I can't see how to pull up older runs easily on github for comparison, so I'm not sure if the download is faster but it seems sufficiently fast.

BenTheElder commented 1 week ago

/hold-cancel

stmcginnis commented 1 week ago

actions are passing, I lost context and I can't see how to pull up older runs easily on github for comparison, so I'm not sure if the download is faster but it seems sufficiently fast.

Looking under the Actions tab, I took a look at this and past runs.

The current VM/CGroupv2 runs took anywhere between 5:37 and 5.51 for the "Boot Fedora" step.

The same jobs with the "e2e-k8s.sh: support --ginkgo.label-filter" PR took between 4:35 and 5:43.

So very slightly more time with the newer Fedora, but that image is probably very slightly larger than the older one anyway. That seems reasonable to me.

/lgtm

k8s-ci-robot commented 1 week ago

@BenTheElder: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kind-conformance-parallel-ipv6 0ff901d99664e973b1f6d7ac0f68a70e1abea8e6 link true /test pull-kind-conformance-parallel-ipv6
pull-kind-e2e-kubernetes-1-29 0ff901d99664e973b1f6d7ac0f68a70e1abea8e6 link true /test pull-kind-e2e-kubernetes-1-29

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
BenTheElder commented 1 week ago

/hold cancel